From: Joan Bruguera Date: Sun, 13 Sep 2020 07:33:32 +0200 Subject: Get rid of get_fs/set_fs calls in Broadcom WL driver. Origin: https://gist.github.com/joanbm/5c640ac074d27fd1d82c74a5b67a1290 Fixes linux-next where get_fs/set_fs is already removed for some architectures. NB: Some checks in wlc_ioctl_internal are likely superfluous, but I'm not familiar enough with the driver to remove them with confidence. See also: https://lwn.net/Articles/722267/ https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/x86/include/asm/uaccess.h?h=next-20200911&id=47058bb54b57962b3958a936ddbc59355e4c5504 https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/linux/uaccess.h?h=next-20200911&id=5e6e9852d6f76e01b2e6803c74258afa5b432bc5 Signed-off-by: Joan Bruguera --- src/wl/sys/wl_cfg80211_hybrid.c | 29 ++----------------------- src/wl/sys/wl_iw.c | 25 ++-------------------- src/wl/sys/wl_linux.c | 40 ++++++++++++++++++++++++++++++----- src/wl/sys/wl_linux.h | 2 ++ src/wl/sys/wlc_pub.h | 1 + 5 files changed, 42 insertions(+), 55 deletions(-) diff -rup a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c --- a/src/wl/sys/wl_cfg80211_hybrid.c 2020-11-13 08:38:56.883599679 +0100 +++ b/src/wl/sys/wl_cfg80211_hybrid.c 2020-11-13 08:42:07.944320760 +0100 @@ -38,6 +38,7 @@ #include #include #include +#include #define EVENT_TYPE(e) dtoh32((e)->event_type) #define EVENT_FLAGS(e) dtoh16((e)->flags) @@ -436,30 +437,8 @@ static void key_endian_to_host(struct wl static s32 wl_dev_ioctl(struct net_device *dev, u32 cmd, void *arg, u32 len) { - struct ifreq ifr; - struct wl_ioctl ioc; - mm_segment_t fs; - s32 err = 0; - BUG_ON(len < sizeof(int)); - - memset(&ioc, 0, sizeof(ioc)); - ioc.cmd = cmd; - ioc.buf = arg; - ioc.len = len; - strcpy(ifr.ifr_name, dev->name); - ifr.ifr_data = (caddr_t)&ioc; - - fs = get_fs(); - set_fs(get_ds()); -#if defined(WL_USE_NETDEV_OPS) - err = dev->netdev_ops->ndo_do_ioctl(dev, &ifr, SIOCDEVPRIVATE); -#else - err = dev->do_ioctl(dev, &ifr, SIOCDEVPRIVATE); -#endif - set_fs(fs); - - return err; + return wlc_ioctl_internal(dev, cmd, arg, len); } #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) diff -rup a/src/wl/sys/wl_iw.c b/src/wl/sys/wl_iw.c --- a/src/wl/sys/wl_iw.c 2020-11-13 08:38:56.891599715 +0100 +++ b/src/wl/sys/wl_iw.c 2020-11-13 08:40:14.803914270 +0100 @@ -37,6 +37,7 @@ typedef const struct si_pub si_t; #include #include +#include extern bool wl_iw_conn_status_str(uint32 event_type, uint32 status, uint32 reason, char* stringBuf, uint buflen); @@ -106,29 +107,7 @@ dev_wlc_ioctl( int len ) { - struct ifreq ifr; - wl_ioctl_t ioc; - mm_segment_t fs; - int ret; - - memset(&ioc, 0, sizeof(ioc)); - ioc.cmd = cmd; - ioc.buf = arg; - ioc.len = len; - - strcpy(ifr.ifr_name, dev->name); - ifr.ifr_data = (caddr_t) &ioc; - - fs = get_fs(); - set_fs(get_ds()); -#if defined(WL_USE_NETDEV_OPS) - ret = dev->netdev_ops->ndo_do_ioctl(dev, &ifr, SIOCDEVPRIVATE); -#else - ret = dev->do_ioctl(dev, &ifr, SIOCDEVPRIVATE); -#endif - set_fs(fs); - - return ret; + return wlc_ioctl_internal(dev, cmd, arg, len); } static int diff -rup a/src/wl/sys/wl_linux.c b/src/wl/sys/wl_linux.c --- a/src/wl/sys/wl_linux.c 2020-11-13 08:39:05.659639371 +0100 +++ b/src/wl/sys/wl_linux.c 2020-11-13 08:40:14.803914270 +0100 @@ -1649,10 +1649,7 @@ wl_ioctl(struct net_device *dev, struct goto done2; } - if (segment_eq(get_fs(), KERNEL_DS)) - buf = ioc.buf; - - else if (ioc.buf) { + if (ioc.buf) { if (!(buf = (void *) MALLOC(wl->osh, MAX(ioc.len, WLC_IOCTL_MAXLEN)))) { bcmerror = BCME_NORESOURCE; goto done2; @@ -1673,7 +1670,7 @@ wl_ioctl(struct net_device *dev, struct WL_UNLOCK(wl); done1: - if (ioc.buf && (ioc.buf != buf)) { + if (ioc.buf) { if (copy_to_user(ioc.buf, buf, ioc.len)) bcmerror = BCME_BADADDR; MFREE(wl->osh, buf, MAX(ioc.len, WLC_IOCTL_MAXLEN)); @@ -1683,6 +1680,39 @@ done2: ASSERT(VALID_BCMERROR(bcmerror)); if (bcmerror != 0) wl->pub->bcmerror = bcmerror; + return (OSL_ERROR(bcmerror)); +} + +int +wlc_ioctl_internal(struct net_device *dev, int cmd, void *buf, int len) +{ + wl_info_t *wl; + wl_if_t *wlif; + int bcmerror; + + if (!dev) + return -ENETDOWN; + + wl = WL_INFO(dev); + wlif = WL_DEV_IF(dev); + if (wlif == NULL || wl == NULL || wl->dev == NULL) + return -ENETDOWN; + + bcmerror = 0; + + WL_TRACE(("wl%d: wlc_ioctl_internal: cmd 0x%x\n", wl->pub->unit, cmd)); + + WL_LOCK(wl); + if (!capable(CAP_NET_ADMIN)) { + bcmerror = BCME_EPERM; + } else { + bcmerror = wlc_ioctl(wl->wlc, cmd, buf, len, wlif->wlcif); + } + WL_UNLOCK(wl); + + ASSERT(VALID_BCMERROR(bcmerror)); + if (bcmerror != 0) + wl->pub->bcmerror = bcmerror; return (OSL_ERROR(bcmerror)); } diff -rup a/src/wl/sys/wl_linux.h b/src/wl/sys/wl_linux.h --- a/src/wl/sys/wl_linux.h 2015-09-19 00:47:30.000000000 +0200 +++ b/src/wl/sys/wl_linux.h 2020-11-13 08:40:14.803914270 +0100 @@ -22,6 +22,7 @@ #define _wl_linux_h_ #include +#include typedef struct wl_timer { struct timer_list timer; @@ -187,6 +188,7 @@ extern irqreturn_t wl_isr(int irq, void extern int __devinit wl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent); extern void wl_free(wl_info_t *wl); extern int wl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd); +extern int wlc_ioctl_internal(struct net_device *dev, int cmd, void *buf, int len); extern struct net_device * wl_netdev_get(wl_info_t *wl); #endif diff -rup a/src/wl/sys/wlc_pub.h b/src/wl/sys/wlc_pub.h --- a/src/wl/sys/wlc_pub.h 2015-09-19 00:47:30.000000000 +0200 +++ b/src/wl/sys/wlc_pub.h 2020-11-13 08:40:14.803914270 +0100 @@ -24,6 +24,7 @@ #include #include +#include #include "proto/802.11.h" #include "proto/bcmevent.h"